Skip to content

feat(GlFormSelect): update stories and add specs

David O'Regan requested to merge form-select-computed-state into master

What does this MR do?

A small update for the GlFormSelect where we update how the story is handled for state, abstract some extra variables to share between our story and specs, add supporting specs and extend the story to show valid/invalid states.

Screenshot_2020-12-17_at_09.37.14

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • [-] If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by David O'Regan

Merge request reports