Skip to content

fix(GlFormSelect): fix inconsistent select disabled state

David O'Regan requested to merge 1017-inconsistent-dropdowns into master

What does this MR do?

A tiny MVC to handle #1017 (closed) where we align the select disabled state with the rest of the form inputs. Ideally we could share the styling between gl-form-input and the select component but this creates some strange bugs, perhaps we could abstract the disabled state to a shared mixin in a follow-up?

Screenshot_2020-12-04_at_07.19.39

Screenshot_2020-12-04_at_07.20.13

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • [-] If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #1017 (closed)

Edited by David O'Regan

Merge request reports