Skip to content

feat(css): Add new width variable

Alexander Turinske requested to merge 287726-create-reusable-widths into master

What does this MR do?

feat: adding new width variable

  • in several locations in our app we are using w-15p, so I added gl-w-15p
❯ git grep w-15p
app/assets/javascripts/alert_management/components/alert_management_table.vue:      thClass: `${thClass} js-started-at w-15p`,
app/assets/javascripts/alert_management/components/alert_management_table.vue:      thClass: `${thClass} w-15p`,
app/assets/javascripts/error_tracking/components/error_tracking_list.vue:      thClass: 'w-15p',
app/assets/javascripts/incidents/components/incidents_list.vue:      thClass: `${thClass} w-15p`,
app/assets/javascripts/incidents/components/incidents_list.vue:      thClass: 'gl-pointer-events-none w-15p',
app/assets/javascripts/incidents/components/incidents_list.vue:      thClass: `${thClass} w-15p`,
app/assets/stylesheets/framework/common.scss:.w-15p { width: 15%; }

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Sarah Groff Hennigh-Palermo

Merge request reports