Skip to content

Change default category for GlDropdown to primary

Savas Vedova requested to merge fix-default-category-for-dropdowns into master

What does this MR do?

This changes the default category of the dropdown to primary. Currently it defaults to tertiary.

In !1805 (merged), styling of the tertiary category for dropdowns was implemented. Prior to that, the tertiary category's styling was equivalent to the primary category's styling.

But, since the default category for the dropdown button was tertiary, that meant that all dropdowns which didn't explicitly set the category to primary changed in appearance.

Pajamas currently specifies that a button's default category is tertiary, but GlButton defaults to primary. So, this change makes GlDropdown agree with GlButton, but not Pajamas. This discrepancy will be dealt with in another MR.

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.
Edited by Mark Florian

Merge request reports