Friendly wrap without v-html
What does this MR do?
refactor(GlFriendlyWrap): Avoid v-html
This is marked as a refactor, but it does in fact slightly alter the
behaviour of GlFriendlyWrap
in two ways:
- Characters that are escaped via
lodash/escape
can be used as symbols in their raw form now, rather than in their escaped forms as HTML entities. - If the provided text string ends in a word break symbol, the
component no longer appends a final
<wbr>
, since it's not necessary; by definition, there's nothing left to wrap at the end of the string!
So, while these are technically changes in behavior, they seem sensible, sufficiently minor and unlikely to affect any real world usage that it doesn't seem appropriate to mark this as a breaking change.
Does this MR meet the acceptance criteria?
Conformity
-
Code review guidelines. -
GitLab UI's contributing guidlines. - [-] If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
- [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
- [-] If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the
@gitlab/ui
package can be upgraded quickly after the changes are released:-
GitLab: mr_url -
CustomersDot: mr_url -
Status Page: mr_url
-
- [-] Added the
~"component:*"
label(s) if applicable.
Edited by Mark Florian