Skip to content

fix(GlIcon): Make icons decorative

Coung Ngo requested to merge cngo-make-icons-decorative into master

What does this MR do?

Since the majority use of icons is decorative, this MR defaults them to hidden for screen readers to reduce noise and minimise the existence of icons lacking in accessible labels. In the case that an icon is given an aria-label value, this is used and the icon is not hidden to screen readers.

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports