Skip to content

fix(GlPagination): Remove examples not recommended by Pajamas

Jarek Ostrowski requested to merge 1034-update-pagination-figma-parity into master

What does this MR do?

Removes the examples that don't align with our Pajamas docs or our Figma designs. This is an effort to bring parity between gitlab-ui and Pajamas through this audit issue.

I didn't find much info as to why we have these examples, but I suspect they were added as the out-of-the-box spec from bootstrap: https://bootstrap-vue.org/docs/components/pagination.

Before After
Screen_Shot_2020-10-20_at_11.40.03_AM Screen_Shot_2020-10-20_at_11.38.53_AM

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #1034 (closed)

Edited by Jarek Ostrowski

Merge request reports