Skip to content

fix(GlPagination): Fix extra space between span and icon

Jarek Ostrowski requested to merge 1021-fix-pagination-text-space into master

What does this MR do?

Closes #1021 (closed). Adds gl-display-flex to the Next and Prev buttons to remove the extra added white-space on the inner text span element. The current implementation does not match the design spec in Figma.

There are a number of ways to do this, but felt adding the gl-display-flex would be the simplest solution. However, I'm open to other solutions as well.

Screenshots

Before After
Screen_Shot_2020-10-20_at_9.59.31_AM Screen_Shot_2020-10-20_at_9.59.42_AM

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #1021 (closed)

Edited by Jarek Ostrowski

Merge request reports