Skip to content

Add "link" variant as valid option for dropdowns

Mike Greiling requested to merge mg-fix-missing-dropdown-variant into master

What does this MR do?

Addresses #1030 (closed) and the issue encountered in gitlab!41429 (comment 431171931) where link is not considered a valid variant for gl-dropdown.

Screenshots

CleanShot_2020-10-16_at_16.20.59_2x

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Mike Greiling

Merge request reports