Skip to content

fix: exclude chart component from main components index

Simon Knox requested to merge psi-no-gauge into master

What does this MR do?

Don't include charts component in main gitlab-ui export, so echarts isn't included in main.js bundle. Fixes gitlab#250647 (closed)

webpack bundle analyser of main.js in gitlab:

before after
Screen_Shot_2020-09-17_at_9.11.14_pm Screen_Shot_2020-09-17_at_9.09.59_pm

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.
Edited by Simon Knox

Merge request reports