Skip to content

test(visual): Make async tests more stable

Lukas 'ai-pi' Eipert requested to merge 990-fix-flaky-tests into master

What does this MR do?

Certain documented stories use timeouts to mimic async behaviour. In order to not have flaky tests, we introduce a helper that executes those functions immediately in case of visual tests.

Also adding a linting rule to hint towards that new helper.

See #990 (closed)

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Closes #990 (closed)

Edited by Lukas 'ai-pi' Eipert

Merge request reports