Skip to content

fix(GlToggle): prevent default on click

Paul Gascou-Vaillancourt requested to merge toggle-click-preventdefault into master

What does this MR do?

Fixes a bug where clicking on the toggle's icon would trigger the click handler twice, resulting in the toggle being immediately switched back to its initial state.

Before After
before after

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • [-] If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Closes #973 (closed)

Edited by Paul Gascou-Vaillancourt

Merge request reports