Skip to content

fix(GlIcon): Force rerendering of icons if the icon changes

Lukas 'ai-pi' Eipert requested to merge leipert-svg-key into master

What does this MR do?

If we dynamically change icons we force a rerender. Otherwise in Chrome 84 we might show outdated icons: gitlab#230433 (comment 391410490)

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.
Edited by Lukas 'ai-pi' Eipert

Merge request reports