Skip to content

fix(GlButton): Disabled state not working if button is a link-button

Constantin Metz requested to merge Keimeno/gitlab-ui:fix/900-button-disabled into master

What does this MR do?

Fixes #900 (closed)

Adds the CSS not selector for all .disabled classes as well. As link-button doesn't have the disabled attribute, it only receives the class.

Also had to unset the pointer-events in order to show the not-allowed cursor. Also had to add the :not(.disabled):not(:disabled) check when setting the focus.

Thanks @psimyn for your advice on adding the .disabled class to the checks.

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Merge request reports