Skip to content

fix: fix occasionally invisible box-shadow in Edge

Simon Knox requested to merge no-rem-for-border-widths into master

What does this MR do?

Use px for border widths rather than rem. We don't need border widths to scale based on user's font size

with px-to-rem we were getting rounding issues:

    px-to-rem(1px) == 0.06rem
    0.06 * 16 = 0.96, i.e. less than 1px!

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.
Edited by Simon Knox

Merge request reports