Skip to content

fix(buttons): Update button states to match specs

Taurie Davis requested to merge 838-button-states into master

What does this MR do?

Button State Before After
Default Resting Screen_Shot_2020-07-15_at_12.51.53_PM Screen_Shot_2020-07-15_at_12.52.57_PM
Default Hover Screen_Shot_2020-07-15_at_12.52.06_PM Screen_Shot_2020-07-15_at_12.53.06_PM
Default Focus Screen_Shot_2020-07-15_at_12.52.11_PM Screen_Shot_2020-07-15_at_12.53.10_PM
Default Active Screen_Shot_2020-07-15_at_12.52.15_PM Screen_Shot_2020-07-15_at_12.53.13_PM
Default Selected Screen_Shot_2020-07-15_at_12.54.35_PM Screen_Shot_2020-07-15_at_12.54.14_PM
Dashed Resting Screen_Shot_2020-07-15_at_12.55.04_PM Screen_Shot_2020-07-16_at_9.47.30_AM
Dashed Hover Screen_Shot_2020-07-15_at_12.55.12_PM Screen_Shot_2020-07-16_at_9.44.26_AM
Dashed Focus Screen_Shot_2020-07-15_at_12.55.17_PM Screen_Shot_2020-07-16_at_9.53.27_AM
Dashed Active Screen_Shot_2020-07-15_at_12.55.21_PM Screen_Shot_2020-07-16_at_9.53.21_AM
Disabled Resting Screen_Shot_2020-07-15_at_12.57.04_PM Screen_Shot_2020-07-15_at_3.39.12_PM
Loading Resting Screen_Shot_2020-07-15_at_12.57.22_PM Screen_Shot_2020-07-15_at_3.39.17_PM
Label Resting Screen_Shot_2020-07-15_at_12.58.04_PM Screen_Shot_2020-07-15_at_12.58.53_PM
Primary Info Resting Screen_Shot_2020-07-15_at_1.02.22_PM Screen_Shot_2020-07-15_at_1.03.07_PM
Primary Info Hover Screen_Shot_2020-07-15_at_1.02.27_PM Screen_Shot_2020-07-15_at_1.03.14_PM
Primary Info Focus Screen_Shot_2020-07-15_at_1.02.31_PM Screen_Shot_2020-07-15_at_1.03.19_PM
Primary Info Active Screen_Shot_2020-07-15_at_1.02.35_PM Screen_Shot_2020-07-15_at_1.03.22_PM
Secondary Info Resting Screen_Shot_2020-07-15_at_1.04.00_PM Screen_Shot_2020-07-15_at_1.04.39_PM
Secondary Info Hover Screen_Shot_2020-07-15_at_1.04.04_PM Screen_Shot_2020-07-15_at_1.04.42_PM
Secondary Info Focus Screen_Shot_2020-07-15_at_1.04.08_PM Screen_Shot_2020-07-15_at_1.04.47_PM
Secondary Info Active Screen_Shot_2020-07-15_at_1.04.11_PM Screen_Shot_2020-07-15_at_1.04.50_PM
Primary Success Resting Screen_Shot_2020-07-15_at_1.05.52_PM Screen_Shot_2020-07-15_at_1.07.43_PM
Primary Success Hover Screen_Shot_2020-07-15_at_1.05.56_PM Screen_Shot_2020-07-15_at_1.07.47_PM
Primary Success Focus Screen_Shot_2020-07-15_at_1.05.59_PM Screen_Shot_2020-07-15_at_1.07.50_PM
Primary Success Active Screen_Shot_2020-07-15_at_1.06.03_PM Screen_Shot_2020-07-15_at_1.07.53_PM
Secondary Success Resting Screen_Shot_2020-07-15_at_1.07.03_PM Screen_Shot_2020-07-15_at_1.08.33_PM
Secondary Success Hover Screen_Shot_2020-07-15_at_1.07.07_PM Screen_Shot_2020-07-15_at_1.08.37_PM
Secondary Success Focus Screen_Shot_2020-07-15_at_1.07.10_PM Screen_Shot_2020-07-15_at_1.08.41_PM
Secondary Success Active Screen_Shot_2020-07-15_at_1.07.14_PM Screen_Shot_2020-07-15_at_1.08.45_PM
Primary Warning Resting Screen_Shot_2020-07-15_at_1.09.35_PM Screen_Shot_2020-07-15_at_1.10.57_PM
Primary Warning Hover Screen_Shot_2020-07-15_at_1.09.40_PM Screen_Shot_2020-07-15_at_1.11.00_PM
Primary Warning Focus Screen_Shot_2020-07-15_at_1.09.43_PM Screen_Shot_2020-07-15_at_1.11.03_PM
Primary Warning Active Screen_Shot_2020-07-15_at_1.09.48_PM Screen_Shot_2020-07-15_at_1.11.07_PM
Secondary Warning Resting Screen_Shot_2020-07-15_at_1.09.54_PM Screen_Shot_2020-07-15_at_1.11.14_PM
Secondary Warning Hover Screen_Shot_2020-07-15_at_1.09.58_PM Screen_Shot_2020-07-15_at_1.11.18_PM
Secondary Warning Focus Screen_Shot_2020-07-15_at_1.10.01_PM Screen_Shot_2020-07-15_at_1.11.21_PM
Secondary Warning Active Screen_Shot_2020-07-15_at_1.10.05_PM Screen_Shot_2020-07-15_at_1.11.25_PM
Primary Danger Resting Screen_Shot_2020-07-15_at_1.12.30_PM Screen_Shot_2020-07-15_at_1.13.46_PM
Primary Danger Hover Screen_Shot_2020-07-15_at_1.12.34_PM Screen_Shot_2020-07-15_at_1.13.49_PM
Primary Danger Focus Screen_Shot_2020-07-15_at_1.12.37_PM Screen_Shot_2020-07-15_at_1.13.53_PM
Primary Danger Active Screen_Shot_2020-07-15_at_1.12.41_PM Screen_Shot_2020-07-15_at_1.13.56_PM
Secondary Danger Resting Screen_Shot_2020-07-15_at_1.12.49_PM Screen_Shot_2020-07-15_at_1.14.03_PM
Secondary Danger Hover Screen_Shot_2020-07-15_at_1.12.52_PM Screen_Shot_2020-07-15_at_1.14.07_PM
Secondary Danger Focus Screen_Shot_2020-07-15_at_1.12.56_PM Screen_Shot_2020-07-15_at_1.14.11_PM
Secondary Danger Active Screen_Shot_2020-07-15_at_1.13.00_PM Screen_Shot_2020-07-15_at_1.14.14_PM
Button link Resting Screen_Shot_2020-07-16_at_9.49.45_AM Screen_Shot_2020-07-16_at_10.27.28_AM
Button link Hover Screen_Shot_2020-07-16_at_9.50.07_AM Screen_Shot_2020-07-16_at_10.27.34_AM
Button link Focus Screen_Shot_2020-07-16_at_9.50.07_AM Screen_Shot_2020-07-16_at_10.27.39_AM
Button link Active Screen_Shot_2020-07-16_at_9.50.07_AM Screen_Shot_2020-07-16_at_10.27.44_AM

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • [-] If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Closes #838 (closed)

Edited by Taurie Davis

Merge request reports