Skip to content

feat(modal): Set modal max height dynamically

Enrique Alcántara requested to merge dynamic-max-height-modals into master

What does this MR do?

  • Calculates the max-height of a modal box based on the viewport’s height.
  • A vertical scroll appears when the modal’s content overflows the modal’s body height.

Screenshots

Small screen Default
Screen_Shot_2020-06-05_at_9.39.19_AM Screen_Shot_2020-06-05_at_9.39.06_AM
Loom video
Loom thumbnail
Link

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.
Edited by Dimitrie Hoekstra

Merge request reports