Skip to content

fix(label): Make dark scoped label text compatible with dark theme

Simon Knox requested to merge dark-labels into master

What does this MR do?

For scoped labels with black text, use class rather than style. Removing the JS dep makes this friendly with dark mode

Fixes the 'text not readable' issue shown in gitlab!28252 (comment 340886381)

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.
Edited by Simon Knox

Merge request reports