Skip to content

refactor(Charts): abstract repeated logic in charts

Andrei Stoicescu requested to merge astoicescu/abstractRepeatedLogicInCharts into main

What does this MR do?

We repeat a lot of logic in the charts test specs.

We could abstract the legend specs into their own file and then in each file test a unique use case for the legend itself.

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Merge request reports