Skip to content

Style form_input/textarea readonly example

David O'Regan requested to merge 759 into master

What does this MR do?

A tiny MVC for: #759 (closed)

In the text area example, the plaintext/readonly example shows the incorrect styles as it does not have disabled applied to it. To fix that, we add the correct property to the example ensuring the styles are correct.

The disabled styles for the regular form_input.vue are correct 🍾

Screenshots

Screenshot_2020-05-05_at_14.42.18

Questions

  1. In the design guidelines, I cannot find a style guide for just a plaintext property, nor does the regular form input have an example for this. Should we both add an example there and update the styles of the bootstrap-vue plaintext to mimic the disabled styles?

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.
Edited by Taurie Davis

Merge request reports