Skip to content

Align dropdown component with spec part 2

Coung Ngo requested to merge cngo/align-dropdown-component-with-spec-part-2 into master

This MR updates the new-dropdown component to further align with the specs: https://gitlab-org.gitlab.io/gitlab-design/hosted/design-gitlab-specs/dropdown-spec-previews/. The new-dropdown component will eventually replace the current dropdown component.

Changes:

  • The new-dropdown-check-item was removed
  • The new-dropdown-item now has the ability to show:
    • A check mark
    • A gitlab-ui svg icon and color to the left
    • An avatar
    • Secondary text
    • A gitlab-ui svg icon to the right
  • Updated examples and stories

Deployment to view the code changes: http://cngo-align-dropdown-component-with-spec-part-2.162.243.131.170.nip.io/?path=/story/base-new-dropdown--default

Issue: gitlab-org/gitlab-services/design.gitlab.com#274 (closed)

Screenshots

Stories before Stories after
Screenshot_2020-02-26_at_4.52.08_pm Screenshot_2020-02-26_at_4.52.17_pm

Added to new-dropdown:

Screenshot_2020-02-26_at_4.42.10_pm Screenshot_2020-02-26_at_4.42.16_pm Screenshot_2020-02-26_at_4.42.23_pm Screenshot_2020-02-26_at_4.42.28_pm
Edited by Coung Ngo

Merge request reports