Add shift padding to dropdowns by default
Description
Should we add padding to shift in our dropdowns?
shift({
padding: 4 // 4px (.25rem),
})
We are seeing great results on the "Create" (+
) and user dropdowns in the navbar:
"Create" menu | User menu |
---|---|
If so, should it be the same to all dropdowns, or do we need to make it configurable.
Original Discussion
The following discussion from !4095 (merged) should be addressed:
-
@pgascouvaillancourt started a discussion: (+11 comments)
As to the adjustements I had to make:
- I had to provide some padding to the
shift
middleware to keep some spacing between the dropdown and the viewport's edges. IMO, this could be added in this MR, WDYT @mrincon?
Edited by Miguel Rincon