Add gl-max-w-0 utility class

added frontend groupproduct analytics maintenancerefactor typemaintenance labels

assigned to @jiaan

added devopsanalyze sectionanalytics labels

mentioned in merge request gitlab!105372 (merged)

mentioned in merge request !3191 (merged)

Setting label(s) ~"Category:Product Analytics" based on groupproduct analytics.

added Category:Product Analytics Visualization label

since this is only ever going to be used for table cells (I think?) would it make more sense to add this to table css instead? This util class doesn't have any other use cases that i know of

@psimyn thanks for checking in on this issue!

since this is only ever going to be used for table cells

Most probably that would be the case.

would it make more sense to add this to table css instead?

That seems sensible. Do you have a suggestion for the class name in that case? I only saw one example and the convention is gl-table-{table-property}-{value}, so should we name this gl-table-max-w-0? That doesn't seem right though.

/cc @ali_o_kan since you are working on the MR

@jiaan I was thinking more like making it a separate prop on gl-table-lite. And I guess if using util class in the component then we would still just want gl-max-w-0 - I agree there's no need to make it specific to table.

<gl-table-light :fields="fields" responsive truncate-cells />

Then in that component the truncateCells prop could add gl-text-truncate max-w-0 classes to tdClass.

This is possibly overthinking it, I don't feel particularly strongly either way

@psimyn To be sure to understand. Do we keep the current implementation in !3191 (merged) as it is, or we move gl-max-w-0 in table.scss?

Thanks @psimyn, in that case we can get !3191 (merged) into the final review & merged.

closed with merge request !3191 (merged)

mentioned in commit d86d8dbf

mentioned in merge request gitlab!122746 (merged)

Add gl-max-w-0 utility class

Problem to solve

Improvements

Designs

Child items 0

Activity