Proper promise rewrite of svg sprite function
Purpose
Proper promise rewrite of svg sprite function
Currently we do a lot of things in the spriter.compile
callback.
If we wrap that code in a more simple manner, we can make it more easy
to follow as we unwrap multiple levels of try catch.
Screenshots
Checklist
For a new icon and/or illustration:
-
Link to related design issue: -
If this adds an icon ensure that it follows the new icon checklists. -
If this adds an illustration ensure that it follows the new illustration checklists.
For third-party trademarks:
-
If this adds or updates an icon or illustration that includes a third-party trademark, ensure that it follows the process for adding third-party trademarks to GitLab.
Merge request reports
Activity
assigned to @leipert
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Stanislav Lashmanov ( @slashmanov
) (UTC+4, 2 hours ahead of@leipert
)Phil Hughes ( @iamphill
) (UTC+1, 1 hour behind@leipert
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by 🤖 GitLab Bot 🤖
@leipert - please add typebug typefeature, typemaintenance or a subtype label to this merge request.- typebug: Defects in shipped code and fixes for those defects. This includes all the bug types (availability, performance, security vulnerability, mobile, etc.)
- typefeature: Effort to deliver new features, feature changes & improvements. This includes all changes as part of new product requirements like application limits.
- typemaintenance: Up-keeping efforts & catch-up corrective improvements that are not Features nor Bugs. This includes restructuring for long-term maintainability, stability, reducing technical debt, improving the contributor experience, or upgrading dependencies.
See the handbook for more guidance on classifying.
This message was created with automation and Engineering Productivity is looking for feedback in this issue:
https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/issues/43
added maintenancerefactor label
added typemaintenance label
Setting label groupfoundations based on
@leipert
's group.added groupfoundations label
Setting label(s) ~"devops::ecosystem" sectiondev based on groupfoundations.
added sectiondev + 1 deleted label
added 32 commits
-
b9a2a7e4...8aa22843 - 31 commits from branch
main
- cf120c6b - Proper promise rewrite of svg sprite function
-
b9a2a7e4...8aa22843 - 31 commits from branch
added 1 commit
- 412781f1 - Proper promise rewrite of svg sprite function
added 1 commit
- 3c7a7bcd - ci: Switch to design.gitlab.com as a review app
added devopsmanage label and removed 1 deleted label
Security policy violations have been resolved.
Edited by GitLab Security Bot