Skip to content

Update Slack logo

Tom Quirk requested to merge update-slack-logo into main

Purpose

Related issue: gitlab#337909 (closed)

Updates Slack logo to be the latest logo. Source: https://brandfolder.com/slack/logos

Concept

The Slack logo is used in one place in the main GitLab repo: the GitLab for Slack application page: gitlab#337909 (closed).

Before After
Screen_Shot_2021-08-09_at_3.48.53_pm Screen_Shot_2021-08-09_at_4.04.28_pm
Screen_Shot_2021-08-09_at_4.05.03_pm Screen_Shot_2021-08-09_at_4.03.46_pm

Checklists

Complete all items in both checklists before closing the issue. All items are the responsibility of the author, unless otherwise noted.

Design

  1. Duplicate the Illustration template and move the copy to your Drafts folder in Figma. Update the file name and cover thumbnail with relevant issue information.
  2. Share your draft file with a FE/UX Foundation designer to review, and make sure they have view permissions in Figma. If they have the capacity, they should assign themselves to this issue. If not, try pinging another designer.
  3. Reviewer: Review the illustration in the author’s draft file. Add design-specific comments in Figma to maintain context. Add general comments to this issue, including your approval status. Once approved, assign to a Figma maintainer for final review.
  4. Maintainer: Add the illustration to the Illustrations file under the appropriate page and category. The illustration should be in a frame with the bounds set to the artwork. The frame name should match the exported file name (without the extension).
  5. Author: Move your draft file to the Component archive Figma project.

Library addition

  1. Create a new merge request (MR) from this issue.
  2. Checkout the new branch locally.
  3. Export the illustration from the Illustrations file (in Figma) to the /illustrations folder in your local instance of the repo. The file name should be lowercase, and use hyphens as a separator between terms. If necessary, place the illustration in one of the sub-directories.
  4. In a terminal window, run yarn run dev to preview the SVG library locally. Find the new illustration and ensure it is rendered accurately.
  5. After you’ve committed the changes and the pipeline passes, double-check your icon in the review app and test that it matches your expectations.
  6. Assign the MR to a review by a maintainer, and proceed with any changes.

If you run into any problems, ensure that all other steps in the project README have been followed.

Links / references

Edited by Tom Quirk

Merge request reports