Symlink arrow icon
Purpose
The arrow icon representing symlink files doesn’t exist in file_icons.svg
as a sprite, and no current sprite would replace it. Adding icons to this file is cumbersome, so the solution would be to add a new icon to the SVG library for symlink file types.
This a) provides one specific icon to be used for this file type, and b) avoids using an existing arrow that already has meaning associated with it.
Relates to gitlab#215395 (closed)
Checklists
Complete all items in both checklists before closing the issue. All items are the responsibility of the author, unless otherwise noted.
Design
-
Duplicate the Icon template and move the copy to your Drafts folder in Figma. Update the file name and cover thumbnail with relevant issue information. -
Share your draft file with a FE/UX Foundation designer to review, and make sure they have view permissions in Figma. If they have the capacity, they should assign themselves to this issue. If not, try pinging another Foundations designer. -
Reviewer: Review the icon in the author’s draft file. Add design-specific comments in Figma to maintain context. Add general comments to this issue, including your approval status. Once approved, assign to a Figma maintainer for final review. -
Maintainer: Add the icon to the Pajamas UI Kit file, convert it to a component, and view it in the Assets panel to ensure it aligns with what’s outlined in the document and asset library structure documentation. -
Maintainer: Publish the library changes along with a clear message about the update. -
Author: Move your draft file to the Component archive Figma project.
Library addition
-
Create a new merge request (MR) from this issue. -
Checkout the new branch locally. -
Export the icon component from the Pajamas UI Kit (in Figma) to the /sprite_icons folder in your local instance of the repo. The file name should be lowercase, and use hyphens as a separator between terms. -
Open the SVG you just exported in your code editor and remove fill="none"
from the<svg>
element. -
In a terminal window, run yarn run svg
to add the icon to the library in the /dist folder. -
In a terminal window, run yarn run dev
to preview the SVG library locally. Find the new icon and test it out by changing settings in the Icon configuration panel of the site. The icon should change color and size with no issues. -
After you’ve committed the changes and the pipeline passes, assign the MR to be reviewed and merged by a maintainer, and proceed with any changes. -
Add a read only (FYI) agenda item to the next UX weekly call to inform everyone of the new icon, linking to this issue.
If you run into any problems, ensure that all other steps in the project README have been followed.
Links / references
Edited by Jeremy Elder