Draft: Poc: Use SSH RPC exposed by Workhorse
Related issue: PoC: SSH requests routing (gitlab#438826 - closed)
Merge request reports
Activity
changed milestone to %Backlog
assigned to @igor.drozdov
added devopscreate sectiondev labels
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer @eurie
(UTC-4, 5 hours behind author)
No maintainer available If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue gitlab#438826 (closed)
mentioned in merge request gitlab!146231 (merged)
added 36 commits
-
170a1efc...2d1e3a95 - 34 commits from branch
main
- 46df5eaa - Poc: Use SSH RPC exposed by Workhorse
- 177f34e4 - Send HTTP/1.1 request instead of HTTP/2
-
170a1efc...2d1e3a95 - 34 commits from branch
added 2 commits
added 1 commit
- c194bde3 - Perform gRPC Classify call before /allowed request
102 104 google.golang.org/api v0.155.0 // indirect 103 105 google.golang.org/appengine v1.6.8 // indirect 104 106 google.golang.org/genproto v0.0.0-20240123012728-ef4313101c80 // indirect 105 google.golang.org/genproto/googleapis/api v0.0.0-20240123012728-ef4313101c80 // indirect 106 google.golang.org/genproto/googleapis/rpc v0.0.0-20240123012728-ef4313101c80 // indirect 107 google.golang.org/genproto/googleapis/api v0.0.0-20240125205218-1f4bbc51befe // indirect 108 google.golang.org/genproto/googleapis/rpc v0.0.0-20240125205218-1f4bbc51befe // indirect 107 109 gopkg.in/DataDog/dd-trace-go.v1 v1.32.0 // indirect 108 110 ) 109 111 110 112 exclude github.com/prometheus/client_golang v1.12.1 113 114 replace gitlab.com/gitlab-org/cells/global-service-poc => ./global-service This MR assumes that:
- https://gitlab.com/gitlab-org/tenant-scale-group/pocs/global-service project is cloned into the root of the repo
- Run
make
and./sql-migrate up
- Modify
config.toml
to contains cells addresses:
[database] config_file = "dbconfig.yml" [[cells]] id = 100 name = "cell-1" address = "http://gdk.test:3000" [[cells]] id = 200 name = "cell-2" address = "http://gdk.test:3001"
-
test.db
contains the right claims
irb => require 'sqlite3' => db = SQLite3::Database.new "test.db" => db.execute "INSERT INTO unique_claims (claim_type, claim_name, cell_id, resource_type, resource_id) VALUES (1, 'gitlab-org', 100, 'Group', 2);" => db.execute "INSERT INTO unique_claims (claim_type, claim_name, cell_id, resource_type, resource_id) VALUES (1, 'cell2', 200, 'Group', 35);" => db.execute "SELECT * FROM unique_claims" => [[1, 1, "gitlab-org", "Group", 2, 100, "2024-03-27 20:48:55", "2024-03-27 20:48:55"], [2, 1, "cell2", "Group", 35, 200, "2024-03-27 22:21:18", "2024-03-27 22:21:18"]]
Where (
gitlab-org
, 2) and (cell2
, 35) are the names and ids of your groups on cell-1 and cell-2.100
and200
are the ids of the cells configured inconfig.toml
.- http://localhost:8091/v1/classify?match=0&value=cell2 returns correct data
added 1 commit
- e33bcee6 - Perform gRPC Classify call before /allowed request
added 1 commit
- c4a952fc - Perform gRPC Classify call before /allowed request
mentioned in issue gitlab#456116 (closed)
mentioned in issue gitlab#456118 (closed)
mentioned in issue #762 (closed)
mentioned in issue #763
mentioned in epic &13532
mentioned in issue #764
mentioned in epic &12708
mentioned in merge request !1081 (merged)
mentioned in epic gitlab-org#13532