Skip to content

refactor: success api on acceptance tests

Mohamed Saber requested to merge gitlab-community/gitlab-shell:refactor-success-api-acceptance-tests into main

What does this MR do and why?

This is one step to refactor the acceptance tests.

In this MR I am reusing customHandler to remove customized logic from successAPI function:

  • Reuse customHandler on function TestDiscoverSuccess
  • Reuse customHandler on function TestPersonalAccessTokenSuccess
  • Reuse customHandler on function TestTwoFactorAuthRecoveryCodesSuccess
  • Reuse customHandler on function TwoFactorAuthVerifySuccess
  • Reuse customHandler on function TestGitLfsAuthenticateSuccess
  • Removing all customized logic from successAPI function

Closes: #616 (closed)

How to set up and validate locally

  • Run acceptance tests.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

typemaintenance maintenancerefactor

Edited by Mohamed Saber

Merge request reports