Exclude API errors from error rate (!630) · Merge requests · GitLab.org / gitlab-shell · GitLab

Igor Drozdov requested to merge id-ignore-api-errors into main May 18, 2022

When API isn't responsible or the resource is not accessible (returns 404 or 403), then we shouldn't consider it as an error on gitlab-sshd side.

During the latest rollout, we had the following error rate: https://dashboards.gitlab.net/d/git-main/git-overview?orgId=1&from=1652877337069&to=1652878712155&viewPanel=2213856730&var-PROMETHEUS_DS=Global&var-environment=gprd&var-stage=cny, but most of the errors were API errors: https://log.gprd.gitlab.net/goto/bf1f0780-d6b1-11ec-aade-19e9974a7229. Since gitlab-sshd is not in control of those errors, let's exclude them from the error rate