Skip to content

Revert "Abort long-running unauthenticated SSH connections"

Igor Drozdov requested to merge id-revert-ssh-connection-timeouts into main

This reverts commit 3a2c8f2c.

The commit has been introduced in !582 (merged)

When gitlab-sshd has been released on production, the following errors appeared in the logs:

Screenshot_2022-04-25_at_16.51.26

I haven't managed to reproduce/debug locally, but this kind of error happens when a connection is closed before Gitaly has sent all the data.

Timers in Go are infamous for being hard to set up: https://github.com/golang/go/issues/14383, so let's try and remove this functionality and see whether it helps. Then we can try to add it back carefully.

Merge request reports

Loading