Skip to content

Fix connections duration metrics

Igor Drozdov requested to merge id-fix-connections-duration-metrics into main

We need to pass time.Now as a param, otherwise it's calculated on call

When I perform a git clone that last ~5 seconds:

Before

# HELP gitlab_shell_sshd_connection_duration_seconds A histogram of latencies for connections to gitlab-shell sshd.
# TYPE gitlab_shell_sshd_connection_duration_seconds histogram
gitlab_shell_sshd_connection_duration_seconds_bucket{le="0.005"} 2
gitlab_shell_sshd_connection_duration_seconds_bucket{le="0.025"} 2
gitlab_shell_sshd_connection_duration_seconds_bucket{le="0.1"} 2
gitlab_shell_sshd_connection_duration_seconds_bucket{le="0.5"} 2
gitlab_shell_sshd_connection_duration_seconds_bucket{le="1"} 2
gitlab_shell_sshd_connection_duration_seconds_bucket{le="10"} 2
gitlab_shell_sshd_connection_duration_seconds_bucket{le="30"} 2
gitlab_shell_sshd_connection_duration_seconds_bucket{le="60"} 2
gitlab_shell_sshd_connection_duration_seconds_bucket{le="300"} 2
gitlab_shell_sshd_connection_duration_seconds_bucket{le="+Inf"} 2
gitlab_shell_sshd_connection_duration_seconds_sum 1.1292e-05
gitlab_shell_sshd_connection_duration_seconds_count 2

After

# HELP gitlab_shell_sshd_connection_duration_seconds A histogram of latencies for connections to gitlab-shell sshd.
# TYPE gitlab_shell_sshd_connection_duration_seconds histogram
gitlab_shell_sshd_connection_duration_seconds_bucket{le="0.005"} 0
gitlab_shell_sshd_connection_duration_seconds_bucket{le="0.025"} 0
gitlab_shell_sshd_connection_duration_seconds_bucket{le="0.1"} 0
gitlab_shell_sshd_connection_duration_seconds_bucket{le="0.5"} 0
gitlab_shell_sshd_connection_duration_seconds_bucket{le="1"} 0
gitlab_shell_sshd_connection_duration_seconds_bucket{le="10"} 2
gitlab_shell_sshd_connection_duration_seconds_bucket{le="30"} 2
gitlab_shell_sshd_connection_duration_seconds_bucket{le="60"} 2
gitlab_shell_sshd_connection_duration_seconds_bucket{le="300"} 2
gitlab_shell_sshd_connection_duration_seconds_bucket{le="+Inf"} 2
gitlab_shell_sshd_connection_duration_seconds_sum 8.93303
gitlab_shell_sshd_connection_duration_seconds_count 2
Edited by Igor Drozdov

Merge request reports