Skip to content

Fix two regressions in SSH certificate support (8.1)

Nick Thomas requested to merge (removed):fix-ssh-certificate-regressions-8-1 into 8-1-stable

Fix two regressions in my 2e8b6702 ("Add support for SSH certificate authentication", 2018-06-14) merged in !207 (merged).

This fixes the issue noted in #145 (closed) where the command-line contains things other than the key/user/username, and also a regression where SSH certificates are being used, and the username presented in the key is unknown to GitLab.

In that case, we should log the user in as "Anonymous" (on an instance that allows public access), but because of how the error checking around api.discover() was implemented we ended up erroring out instead.

Closes #145 (closed)

Edited by Nick Thomas

Merge request reports