Refactor that focuses on SRP improvements
Description
This MR aims to improve the code to be in line with the Single Responsibility Principle and also make further MR's easier to work in. Here are the improvements that have been made:
- Move gitaly, git-lfs and 2FA logic out from GitlabShell into Action classes
- Support more accurate HTTP status codes when determining action when talking to the internal API (support still exists for both examining the
status
key (current way) however) - Introduced
Actor::Key
andActor::User
to more accurately map the concepts - Made more methods and attr_(reader|accessor) definitions private
- More heavily use constants
- Gem updates to use latest rspec and vcr
- Running guard now actually works :)
- Remove a bunch of rspec deprecations
- Increased test coverage :)
Related MR's?
What are the relevant issue numbers?
Edited by Ash McKenzie