Remove Ruby Gemfile

What does this MR do and why?

Contributes to #877 (closed)

Problem

gitlab-shell keeps a Ruby Gemfile solely for Danger, causing GDK to install a bundle that is not needed by the application.

Solution

  • Remove the Ruby Gemfile and lockfile.
  • Configure the Danger CI component with the required gitlab-dangerfiles version.
  • Stop ignoring Bundler's .bundle directory.

Blocked (resolved)

Do not merge until GDK skips bundle install for gitlab-shell when no Gemfile exists.

GDK change: gitlab-development-kit!6227 (merged)

Trade-offs

  • Without a committed lockfile, ~> 4.9.2 allows 4.9.x patch releases and Danger's transitive gems resolve to the latest compatible versions on each CI run.
  • Dependency scanning no longer sees the Ruby gems used by the CI-only Danger job. Danger runs only in CI on merge requests.

Validation

Check that the danger-review job passes on this MR. The component creates a Gemfile with gitlab-dangerfiles ~> 4.9.2 in CI and runs the retained Dangerfile.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Vasilii Iakliushin

Merge request reports

Loading
Loading