Skip to content

Remove Ruby implementations of gitlab-shell commands

Once all the functionality in &706 (closed) is added and validated, we'll need to remove lots of ruby code from gitlab-shell. Hopefully all of it :D

Also, as mentioned by @reprazent here (!318 (comment 197620284)):

I think at some point after the migration, we would need to have this buildCommand call return errors: In case something calls gitlab-shell in a way we don't expect.

So instead of checking for the cmd to be nil we should check for an error.

Right now, we're counting on the ruby fallback to deal with that, which is okay for now, but could you create an issue to remove the ruby-fallbacks and mention that issue here?

Since we're removing the ruby implementations in this issue, also change the buildCommand to return an error.

Distinct steps:

Edited by Nick Thomas