Minor updates in the design review process
Problem
The design review process section was added in gitlab-com/www-gitlab-com!26512 (merged) and the trainee design maintainer template was added in gitlab-com/www-gitlab-com!26525 (merged). Both of these great additions include some minor discrepancies when referencing gitlab-ce
, gitlab-ee
, and gitlab-ui
projects.
This proposes some changes in gitlab-org/www-gitlab-com
but added this here as a follow-up for #247 (closed).
Proposal
1. Fix for the design review process section
Here's a minor fix to update gitlab-design
repository reference to follow the pattern used for the rest of the repositories. Also, let's add code spans for the gitlab-ce
, gitlab-ee
, and gitlab-ui
repositories as done in gitlab-com/www-gitlab-com!26525 (diffs)? No need to add the repository link again since this is linked above.
diff --git a/source/handbook/engineering/ux/pajamas-design-system/design-review/index.html.md b/source/handbook/engineering/ux/pajamas-design-system/design-review/index.html.md
index c220a9de42..b7b0514959 100644
--- a/source/handbook/engineering/ux/pajamas-design-system/design-review/index.html.md
+++ b/source/handbook/engineering/ux/pajamas-design-system/design-review/index.html.md
@@ -13,7 +13,7 @@ title: "Design Review Process"
Design reviews are mandatory for every [`design.gitlab.com`](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com), [`gitlab-ui`](https://gitlab.com/gitlab-org/gitlab-ui), and [`gitlab-svgs`](https://gitlab.com/gitlab-org/gitlab-svgs) merge request, as well as for [`gitlab-ce`](https://gitlab.com/gitlab-org/gitlab-ce) and [`gitlab-ee`](https://gitlab.com/gitlab-org/gitlab-ee) merge requests that have the [UX label](https://about.gitlab.com/handbook/engineering/ux/ux-department-workflow/#how-we-use-labels) added to it.
-All designers are maintainers of the [GitLab-design](https://gitlab.com/gitlab-org/gitlab-design) project. If you are interested in becoming a Maintainer of UI (`.scss`) for gitlab-ce, gitlab-ee, and gitlab-ui projects, please follow the [Engineering Review Workflow](/handbook/engineering/workflow/code-review).
+All designers are maintainers of the [`gitlab-design`](https://gitlab.com/gitlab-org/gitlab-design) project. If you are interested in becoming a Maintainer of UI (`.scss`) for gitlab-ce, gitlab-ee, and gitlab-ui projects, please follow the [Engineering Review Workflow](/handbook/engineering/workflow/code-review).
To perform a review, you should familiarize yourself with and follow our [Code Review Guidelines](https://docs.gitlab.com/ee/development/code_review.html), [Design Contribution Guidelines](https://gitlab.com/gitlab-org/gitlab-design/blob/master/CONTRIBUTING.md), and the contribution guidelines for every aforementioned project.
2. Fix for the trainee design maintainer template
The link name was probably replaced by accident.
diff --git a/.gitlab/issue_templates/Trainee design maintainer.md b/.gitlab/issue_templates/Trainee design maintainer.md
index 4c4c158fda..771abc795c 100644
--- a/.gitlab/issue_templates/Trainee design maintainer.md
+++ b/.gitlab/issue_templates/Trainee design maintainer.md
@@ -12,7 +12,7 @@
This is not a checklist, but guidelines that will help you become a mantainer. Remember that there is no specific timeline on this, and that you should work together with your manager and current maintainers.
-All designers are maintainers of [`design.gitlab.com`](https://gitlab.com/gitlab-org/gitlab-design) project. If you are interested in becoming a Maintainer of UI (`.scss`) for `gitlab-ce`, `gitlab-ee`, and `gitlab-ui` projects, please follow the [Engineering Review Workflow](/handbook/engineering/workflow/code-review).
+All designers are maintainers of [`gitlab-design`](https://gitlab.com/gitlab-org/gitlab-design) project. If you are interested in becoming a Maintainer of UI (`.scss`) for `gitlab-ce`, `gitlab-ee`, and `gitlab-ui` projects, please follow the [Engineering Review Workflow](/handbook/engineering/workflow/code-review).
It is up to you to ensure that you are getting enough MRs to review, and of varied types. You could also seek out more reviews from your team, for example by asking for reviews on the `#ux` and `#design-system` Slack channels.