Make GlToast work in Vue 3 compat mode

What does this MR do?

Make GlToast work in Vue 3 compat mode

Fix three issues preventing toasts from rendering correctly in Vue 3 compat (and a pre-existing test ordering bug in Vue 2):

  1. $slots is readonly in Vue 3 compat, so bv-toast.js assigning toast.$slots['toast-title'] silently failed. Set slots on the internal instance (toast.$.slots) as functions for Vue 3.
  2. renderTitle called $createElement outside a render context, which in Vue 3 compat triggers "resolveComponent can only be used in render() or setup()" and produces broken VNodes. Changed renderTitle to return a deferred render function that is called during the slot evaluation in the component's render cycle.
  3. ensureToaster only checked Wormhole.hasTarget() before creating a toaster. If the toaster DOM was removed but the Wormhole registration persisted, no new toaster was created and toasts were portaled to a detached target. Added a DOM existence check to detect and recover from stale toaster state.

Screenshots or screen recordings

Integrations

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • The “What does this MR do?” section in the MR description is filled out, explaining the reasons for and scope of the proposed changes, per “Say why not just what”.
    • For example, if the MR is focused on usage guidelines, addressing accessibility challenges could be added in a separate MR.
  • Relevant label(s) are applied to the MR.
  • The MR is added to a milestone.
  • Added the ~"component:*" label(s) if applicable.
  • A changeset is added when this MR will do a patch, minor, or major update. More information can be found in doc/publishing-packages.md.

Components

Documentation

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Vanessa Otto

Merge request reports

Loading