Skip to content

Fix Playwright CI jobs

Mark Florianrequested to merge
fix-playwright-ci-jobs into main

What does this MR do?

Revert "Bump node version"

This reverts commit bb668eef, and ensures a newer npm version is available for trusted publishing.

As described in !5262 (closed), CI jobs which use the Playwright images were broken due to !5258 (merged).

The reason is that the phantomjs-prebuilt package (needed by svg-sprite from packages/gitlab-svgs) needs bzip2 to be installed, but apparently that's not installed in the Playwright images.

The reason those jobs used to succeed was that the node_modules cache prepared by previous jobs using the node:22.20.0-trixie images (which do have bzip2 installed) can be reused as-is without rebuilding. This is because both images use Node 22.x.

By updating other images to node:24.10.0, that cache isn't useable by the Playwright image, forcing a rebuild in jobs using it, causing the bzip2 failure from above.

So, this restores the utility of the node_modules cache between the images.

The original motivation for the bump to Node 24.x was to get a newer npm version, so trusted publishing would work. Instead, we directly install a newer npm version in the publishing job.

Include package jobs with pipeline:include-* labels

Sometimes it's useful to run the jobs defined in workspace packages without changing any of their files.

Now, the pipeline:include-svgs, pipeline:include-ui, and pipeline:include-tw labels are available to do just that.

Add the labels to a merge request, then trigger a new pipeline, and the respective jobs will be included in the pipeline.

Include svgs: and ui: jobs when CI config changes

If the root CI configuration file changes, include svgs:*, ui:*, and tw:* jobs.

This should help prevent failures like the one caused by !5258 (merged).

Screenshots or screen recordings

Integrations

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • The “What does this MR do?” section in the MR description is filled out, explaining the reasons for and scope of the proposed changes, per “Say why not just what”.
    • For example, if the MR is focused on usage guidelines, addressing accessibility challenges could be added in a separate MR.
  • Relevant label(s) are applied to the MR.
  • The MR is added to a milestone.
  • Added the ~"component:*" label(s) if applicable.
  • A changeset is added when this MR will do a patch, minor, or major update. More information can be found in doc/publishing-packages.md.

Components

Documentation

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Mark Florian

Merge request reports