Skip to content

Remove BNav from vendored BootstrapVue directory

What does this MR do?

Remove BNav from the vendored BootstrapVue directory. The component GlNav does not use BNav anymore and also ttps://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/4901. However, BTabs was still using BNav. This usage is replaced with a custom ul rendering in BTabs now.

Output HTML of Default Story

HTML Output of the Default Story stayed identical.

Before
<div class="tabs gl-tabs" id="__BVID__25"><!----><div class="gl-tabs-wrapper"><!----><ul role="tablist" class="nav gl-tabs-nav" id="__BVID__25__BV_tab_controls_"><!----><li role="presentation" class="nav-item"><a id="__BVID__27___BV_tab_button__" role="tab" aria-selected="true" aria-setsize="14" aria-posinset="1" aria-controls="__BVID__27" href="#" target="_self" class="nav-link active gl-tab-nav-item gl-tab-nav-item-active">Tab 1</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="2" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__30___BV_tab_button__" aria-controls="__BVID__30">Tab 2</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="3" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__33___BV_tab_button__" aria-controls="__BVID__33">Tab 3</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="4" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__36___BV_tab_button__" aria-controls="__BVID__36">Tab 4</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="5" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__39___BV_tab_button__" aria-controls="__BVID__39">Tab 5</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="6" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__42___BV_tab_button__" aria-controls="__BVID__42">Tab 6</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="7" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__45___BV_tab_button__" aria-controls="__BVID__45">Tab 7</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="8" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__48___BV_tab_button__" aria-controls="__BVID__48">Tab 8</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="9" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__51___BV_tab_button__" aria-controls="__BVID__51">Tab 9</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="10" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__54___BV_tab_button__" aria-controls="__BVID__54">Tab 10</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="11" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__57___BV_tab_button__" aria-controls="__BVID__57">Tab 11</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="12" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__60___BV_tab_button__" aria-controls="__BVID__60">Tab 12</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="13" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__63___BV_tab_button__" aria-controls="__BVID__63">Tab 13</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="14" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__66___BV_tab_button__" aria-controls="__BVID__66">Tab 14</a></li><!----></ul><!----></div><div class="tab-content gl-tab-content" id="__BVID__25__BV_tab_container_"><div role="tabpanel" aria-hidden="false" class="tab-pane active" id="__BVID__27" aria-labelledby="__BVID__27___BV_tab_button__" style="">
      Tab panel 1
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__30" aria-labelledby="__BVID__30___BV_tab_button__" style="display: none;">
      Tab panel 2
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__33" aria-labelledby="__BVID__33___BV_tab_button__" style="display: none;">
      Tab panel 3
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__36" aria-labelledby="__BVID__36___BV_tab_button__" style="display: none;">
      Tab panel 4
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__39" aria-labelledby="__BVID__39___BV_tab_button__" style="display: none;">
      Tab panel 5
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__42" aria-labelledby="__BVID__42___BV_tab_button__" style="display: none;">
      Tab panel 6
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__45" aria-labelledby="__BVID__45___BV_tab_button__" style="display: none;">
      Tab panel 7
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__48" aria-labelledby="__BVID__48___BV_tab_button__" style="display: none;">
      Tab panel 8
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__51" aria-labelledby="__BVID__51___BV_tab_button__" style="display: none;">
      Tab panel 9
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__54" aria-labelledby="__BVID__54___BV_tab_button__" style="display: none;">
      Tab panel 10
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__57" aria-labelledby="__BVID__57___BV_tab_button__" style="display: none;">
      Tab panel 11
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__60" aria-labelledby="__BVID__60___BV_tab_button__" style="display: none;">
      Tab panel 12
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" query-param-value="thirteenth" id="__BVID__63" aria-labelledby="__BVID__63___BV_tab_button__" style="display: none;">
      Tab panel 13
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__66" aria-labelledby="__BVID__66___BV_tab_button__" style="display: none;">
      Tab panel 14
    </div><!----></div></div>
After
<div class="tabs gl-tabs" id="__BVID__51"><!----><div class="gl-tabs-wrapper"><!----><ul role="tablist" class="nav gl-tabs-nav" id="__BVID__51__BV_tab_controls_"><!----><li role="presentation" class="nav-item"><a id="__BVID__53___BV_tab_button__" role="tab" aria-selected="true" aria-setsize="14" aria-posinset="1" aria-controls="__BVID__53" href="#" target="_self" class="nav-link active gl-tab-nav-item gl-tab-nav-item-active">Tab 1</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="2" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__56___BV_tab_button__" aria-controls="__BVID__56">Tab 2</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="3" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__59___BV_tab_button__" aria-controls="__BVID__59">Tab 3</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="4" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__62___BV_tab_button__" aria-controls="__BVID__62">Tab 4</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="5" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__65___BV_tab_button__" aria-controls="__BVID__65">Tab 5</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="6" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__68___BV_tab_button__" aria-controls="__BVID__68">Tab 6</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="7" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__71___BV_tab_button__" aria-controls="__BVID__71">Tab 7</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="8" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__74___BV_tab_button__" aria-controls="__BVID__74">Tab 8</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="9" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__77___BV_tab_button__" aria-controls="__BVID__77">Tab 9</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="10" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__80___BV_tab_button__" aria-controls="__BVID__80">Tab 10</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="11" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__83___BV_tab_button__" aria-controls="__BVID__83">Tab 11</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="12" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__86___BV_tab_button__" aria-controls="__BVID__86">Tab 12</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="13" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__89___BV_tab_button__" aria-controls="__BVID__89">Tab 13</a></li><li role="presentation" class="nav-item"><a role="tab" tabindex="-1" aria-selected="false" aria-setsize="14" aria-posinset="14" href="#" target="_self" class="nav-link gl-tab-nav-item" id="__BVID__92___BV_tab_button__" aria-controls="__BVID__92">Tab 14</a></li><!----></ul><!----></div><div class="tab-content gl-tab-content" id="__BVID__51__BV_tab_container_"><div role="tabpanel" aria-hidden="false" class="tab-pane active" id="__BVID__53" aria-labelledby="__BVID__53___BV_tab_button__" style="">
      Tab panel 1
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__56" aria-labelledby="__BVID__56___BV_tab_button__" style="display: none;">
      Tab panel 2
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__59" aria-labelledby="__BVID__59___BV_tab_button__" style="display: none;">
      Tab panel 3
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__62" aria-labelledby="__BVID__62___BV_tab_button__" style="display: none;">
      Tab panel 4
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__65" aria-labelledby="__BVID__65___BV_tab_button__" style="display: none;">
      Tab panel 5
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__68" aria-labelledby="__BVID__68___BV_tab_button__" style="display: none;">
      Tab panel 6
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__71" aria-labelledby="__BVID__71___BV_tab_button__" style="display: none;">
      Tab panel 7
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__74" aria-labelledby="__BVID__74___BV_tab_button__" style="display: none;">
      Tab panel 8
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__77" aria-labelledby="__BVID__77___BV_tab_button__" style="display: none;">
      Tab panel 9
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__80" aria-labelledby="__BVID__80___BV_tab_button__" style="display: none;">
      Tab panel 10
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__83" aria-labelledby="__BVID__83___BV_tab_button__" style="display: none;">
      Tab panel 11
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__86" aria-labelledby="__BVID__86___BV_tab_button__" style="display: none;">
      Tab panel 12
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" query-param-value="thirteenth" id="__BVID__89" aria-labelledby="__BVID__89___BV_tab_button__" style="display: none;">
      Tab panel 13
    </div> <div role="tabpanel" aria-hidden="true" class="tab-pane" id="__BVID__92" aria-labelledby="__BVID__92___BV_tab_button__" style="display: none;">
      Tab panel 14
    </div><!----></div></div>

Integration Branch

GitLab Monolith MR

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • The “What does this MR do?” section in the MR description is filled out, explaining the reasons for and scope of the proposed changes, per “Say why not just what”.
    • For example, if the MR is focused on usage guidelines, addressing accessibility challenges could be added in a separate MR.
  • Relevant label(s) are applied to the MR.
  • The MR is added to a milestone.
  • Added the ~"component:*" label(s) if applicable.

Components

Documentation

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #2311 (closed)

Edited by Vanessa Otto

Merge request reports

Loading