Skip to content

fix(GlBreadcrumbs): Add medium variant of collapse calculation

What does this MR do?

The small size dropdown toggle measures 24px, 26px with the boarder. It's the same for the dropdown toggle, when the dropdown is of size medium. Despite the same toggle size, breadcrumb-item-sm that includes the dropdown toggle measures 46.328px in width, while breadcrumb-item-md with the same toggle measures 47.05px. I believe that the difference in these two widths is what's causing the flickering between the two states.

It's quite hard to reproduce. I was able to do it on the GDK under this url: http://gdk.test:8080/gitlab-org/iglu/-/tree/master/src/test/java/com/example. In that edge case, the first item width when it's still a text is 45.16px for the breadcrumb-item-md with 24.12px of the anchor element inside it.

The problem:

  • Original text item width: 45.16px
  • Dropdown replacement width: 47.05px
  • Current buttonWidth: 40px (too small)

The flickering cycle:

  • Algorithm uses 40px, thinks dropdown will fit → collapses item
  • Actual dropdown renders at 47.05px (larger than original 45.16px text)
  • Now it doesn't fit → tries to uncollapse
  • Back to 45.16px text → cycle repeats

Solution: Set buttonWidth to 48px for medium size breadcrumbs.

Screenshots or screen recordings

Warning

Flickering content in the expandable section

Click to expand
Before After
Screen_Recording_2025-07-09_at_15.36.12 Screen_Recording_2025-07-09_at_15.28.32

Integrations

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • The “What does this MR do?” section in the MR description is filled out, explaining the reasons for and scope of the proposed changes, per “Say why not just what”.
    • For example, if the MR is focused on usage guidelines, addressing accessibility challenges could be added in a separate MR.
  • Relevant label(s) are applied to the MR.
  • The MR is added to a milestone.
  • Added the ~"component:*" label(s) if applicable.

Components

Documentation

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Related to #2915 (closed)

Edited by Paulina Sedlak-Jakubowska

Merge request reports

Loading