Hoist ESLint to root
What does this MR do?
This hoists ESLint tooling/configuration to the root.
This may be easier to review commit-by-commit.
Part of #2034 (closed).
Commits
Don't disable ESLint rule we don't violate
Use modern import.meta for dirname
Disallow ESLint warnings
Fix vue/attributes-order warning
Enable no-param-reassign globally
Only enable vue/multi-word-component-names for Nuxt components
Don't disable ESLint rule we don't violate
Use lodash deep imports
This is so it's consistent with packages/gitlab-ui's ESLint
configuration that will be hoisted in the next commit.
Hoist ESLint to root
- Hoist ESLint dependencies
- Hoist ESLint scripts
- Simplify jestConfig references
- Combine eslint.config.js files
To combine the two eslint.config.js files, I took a couple of steps:
- combine the first configuration objects (which don't have
fileskeys). Theno-restricted-importsrule has to be treated differently and split up, as its configuration is overridden in a later configuration object. I removed thevue/v-no-htmlandmax-paramsrules, since they are already set by@gitlab/eslint-config. - Move the remaining configuration obects, and process them so they only
apply to files under
packages/gitlab-ui, using a method that approximatesbasePath(added in ESLint 9.30.0).
Use lint: prefix for eslint scripts
This avoids shadowing the eslint executable. This means that
yarn eslint will run the plain eslint executable, allowing for
custom calls without having to call node_modules/.bin/eslint.
Tidy up import/no-default-export rule
It's better to specify where it's allowed in one place, rather than peppering the code with inline directives.
Screenshots or screen recordings
N/A
Integrations
-
GitLab: mr_url -
CustomersDot: mr_url -
Duo UI: mr_url -
Status Page: mr_url -
Docs: mr_url -
Switchboard: mr_url
Does this MR meet the acceptance criteria?
This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.
Toggle the acceptance checklist
Conformity
-
The “What does this MR do?” section in the MR description is filled out, explaining the reasons for and scope of the proposed changes, per “Say why not just what”. - For example, if the MR is focused on usage guidelines, addressing accessibility challenges could be added in a separate MR.
-
Relevant label(s) are applied to the MR. -
The MR is added to a milestone. -
Added the ~"component:*"label(s) if applicable.
Components
-
GitLab UI's contributing guidelines. -
If the MR changes a component's API, integration MR(s) have been opened (see integrations above).
Documentation
-
If creating a new component page from scratch, it follows the page template structure. -
Content follows the Pajamas voice and tone guidelines, falling back on the GitLab Documentation Style Guide when needed. -
Related pages are cross-linked, where helpful. Component pages have related components and patterns defined in their Markdown front matter. -
If embedding a Figma file, it follows the Figma embed guide. -
Review requested from any GitLab designer or directly from a maintainer or trainee maintainer. -
Maintainer review follows the Pajamas UX maintainer review checklist.
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
Security reports checked/validated by a reviewer from the AppSec team
Accessibility
If this MR adds or modifies a component, take a few moments to review the following:
-
All actions and functionality can be done with a keyboard. -
Links, buttons, and controls have a visible focus state. -
All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-labelfor icons that have meaning or perform actions. -
Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false"toaria-expanded="true"when an accordion is expanded. -
Color combinations have sufficient contrast.