Skip to content

fix(Stories): Add various storybook stories to component pages

Dan MH requested to merge add-various-storybook-stories-part-2-danmh into main

What does this MR do?

In the recent research we conducted (gitlab-org/ux-research#2413 (closed)), we found that design system consumers having to look in multiple places caused mistakes and frustrations. To reduce that, and move closer to a SSOT, we're exploring making design.gitlab.com fully featured enough to not need to go elsewhere (as have others before gitlab-org/gitlab-ui#888 (comment 1535852676)).

it feels like there needs to be some kind of layout adjustment to accommodate this larger number of examples so that the overall component pages are still usable/digestible.

Agree with this. My thinking is getting the stories in in their current form is an improvement. It moves us away from needing to reference storybook directly. But it also really highlights the opportunities for improving design.gitlab.com. I don't think there is capacity to do these sorts of layout adjustments in this milestone, and I do think this MR takes us in the right direction, so I'd like to proceed.

Label

  • Retitle stories
  • Add with close button

Modal

  • Add scrolling content
  • Add without actions

Pagination

  • Retitle stories to make clear they are offset pagination variants
  • Fix truncated story

Path

  • Add titles
  • Add popover example

Popover

  • Add titles
  • Add with close button

Toast

  • Add action
  • Add long content

Toggle

  • Add left label position

Tooltip

  • Add right
  • Add bottom
  • Add left

Does this MR meet the acceptance criteria?

Links

Edited by Dan MH

Merge request reports