Skip to content

Adds recommendation to default to unique URLs for tabs

Becka Lippert requested to merge beckalippert-main-patch-50408 into main

Problem to solve

In gitlab-org/gitlab#262079 (closed) we're proposing adding a new tab to the Group-level security dashboard, and I checked the tab component in Pajamas to see what the guidance was around whether or not to create a unique URL for each tab. There's currently no mention of this, so I looked around GitLab to see what most pages were doing, and the vast majority of pages use unique URLs for each tab.

Under CI/CD > Editor there are tabs further down the page that don't use a unique URL, which makes sense for the workflow on that page, so I'm proposing to add guidance to have unique URLs for parent tabs (at the top of the page) but that discretion should be used for child tabs (further down the page) and whether or not it makes sense to have unique URLs there.

Open to feedback and suggestions!

FYI

Other pages that don't use unique URLs on tabs:

  • Project information > Activity
  • Security & Compliance > Threat Monitoring
  • Security & Compliance > Configuration
  • Monitor > Incidents

This may have been intentional or not, and should be re-examined on a case-by-case basis. Moving forward it would be good to include a default recommendation in Pajamas to avoid inconsistencies and make sure it's part of the implementation plan.

@gitlab-com/gitlab-ux/designers

Merge request reports