Skip to content

Upgrade eslint-loader

Paul Gascou-Vaillancourt requested to merge upgrade-eslint-loader into master

When running the app with yarn start locally, the build currently throws an error related to ESLint:

 ERROR  Failed to compile with 1 errors                                                                                                                                                                                                                         friendly-errors 11:06:14

Module build failed (from ./node_modules/eslint-loader/index.js):                                                                                                                                                                                               friendly-errors 11:06:14
Error: Cannot find module 'eslint/lib/formatters/stylish'
Require stack:
- /Users/paul/Projects/gitlab/design.gitlab.com/node_modules/eslint-loader/index.js
- /Users/paul/Projects/gitlab/design.gitlab.com/node_modules/loader-runner/lib/loadLoader.js
- /Users/paul/Projects/gitlab/design.gitlab.com/node_modules/loader-runner/lib/LoaderRunner.js
- /Users/paul/Projects/gitlab/design.gitlab.com/node_modules/webpack/lib/NormalModule.js
- /Users/paul/Projects/gitlab/design.gitlab.com/node_modules/webpack/lib/NormalModuleFactory.js
- /Users/paul/Projects/gitlab/design.gitlab.com/node_modules/webpack/lib/Compiler.js
- /Users/paul/Projects/gitlab/design.gitlab.com/node_modules/webpack/lib/webpack.js
- /Users/paul/Projects/gitlab/design.gitlab.com/node_modules/@nuxt/webpack/dist/webpack.js
- /Users/paul/Projects/gitlab/design.gitlab.com/node_modules/@nuxt/cli/dist/cli-chunk.js
- /Users/paul/Projects/gitlab/design.gitlab.com/node_modules/@nuxt/cli/dist/cli.js
- /Users/paul/Projects/gitlab/design.gitlab.com/node_modules/nuxt/bin/nuxt.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:797:15)
    at Function.Module._load (internal/modules/cjs/loader.js:690:27)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.module.exports (/Users/paul/Projects/gitlab/design.gitlab.com/node_modules/eslint-loader/index.js:193:26)

Upgrading eslint-loader to the latest version seems to fix the issue. This upgrade comes with a few breaking changes:

v3.0.0

Breaking Changes

  • drop support for Node < 8.9.0
  • minimum supported webpack version is 4
  • minimum supported eslint version is 5

These breaking changes are acceptable since we already require Node 12, and we use Webpack 4 and ESLint 6.

Edited by Paul Gascou-Vaillancourt

Merge request reports