Rename skeleton components
Problem
Currently, the skeleton-loader
component which includes GlSkeletonLoading
and GlDashboardSkeleton
vue components. Following the discussion in #255 (moved), I think it's also worth harmonizing these names, too.
Both live under skeleton-loader
in the design system in contrast to the gitlab-ui
where they are located under skeleton-loading
.
Proposal
- Document both under the same component name (
loading-skeleton
) (currently documented asskeleton-loader-basic
). - Rename
GlSkeletonLoading
, currently documented asdashboard-skeleton-basic
, toGlLoadingSkeleton
- Rename
GlDashboardSkeleton
, currently documented asdashboard-skeleton-basic
, toGlLoadingSkeletonExpanded
- Update gitlab-ui and design.gitlab.com to reflect the correct grouping. See also gitlab-org/gitlab-ui#234.
Eventually, loading-spinner
could be also included in a common parent component named loading
but let's refrain from doing this at the moment to make these more clear and distinct.