Skip to content

Figma > Links - Update interactive state colors

Description

In !3327 (merged) it was agreed that generally interactive states should have colours 1 stop apart.

This change updates Link components to follow these guidelines.

Components affected

  • ❖ Link / Inline
  • ❖ Link / UI link
  • ❖ Link / Meta link
  • ❖ Link / Mention

Figma file

❖ View working file in Figma →

Checklist

Make sure the following are completed before closing the issue:

Assignee tasks:

Getting started:
  1. Title the issue using this structure "Figma > [Component name] - [Description]". For example, Figma > Badges - Fix icon override bug.
  2. Add the relevant component label. For example component:badge.
  3. If you’re making updates or breaking changes to an existing component in the Pajamas UI Kit, start with a branch of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, #860-table-component-updates-lvanc.
  4. When applicable, follow our structure, building, and annotation guidelines. If you have any questions, reach out to a Foundations designer.
  5. Update the link to the working file under the Figma link section below.
  6. If work was not done in a branch (a merged branch will automatically be archived), move your working file to the shared Figma project:
    1. For Component library changes, move your file to the Component archive project.
    2. For all other changes, move your file to the Misc archive project.
    3. If you’re a community contributor, please consider transferring ownership of your draft file to the maintainer so they can move it to our archive, along with its version history and comments.
Prior to review:

The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma:

  1. Canvas: Make sure no hidden elements have been accidentally left behind. Use View > Show Outlines (⌘ + Y) to reveal invisible objects. Use View > Zoom to Fit (Shift + 1) to view all items on the page.
  2. Components: Where applicable, make sure all components have updated descriptions and have external documentation links.
  3. Frames: Make spacing within and between frames consistent with components found on other pages.
  4. Layers: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order.
  5. Variants: Remove the default dashed purple stroke, border radius, and padding from all variants.
  6. Variants: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order.
  7. Comments: Make sure all comments and discussion are resolved.
Requesting a review:

Ask a Foundations designer to review your design.

  1. Ensure the designer that will be reviewing your file has edit permissions in Figma.
  2. From the dropdown to the right of the file name, select "Request review".
  3. Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column.
  4. Consider creating a new version (optional) titled "Review requested" in the history which will create a reference point in the file's history.

Once your file is in review, you should see a yellow "In review" badge to the right of the file name.

Post review: Once the Reviewer or Maintainer has approved your update, consider the following tasks:
  1. If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
  2. When applicable, add or update relevant documentation and create an MR with your changes using the Documentation MR template. If you do not have the capacity, create another issue using the Component documentation issue template so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
  3. When applicable, create a GitLab UI issue using the Component issue template to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
  4. 🎉 Congrats, you made it! You can now close this issue.

Reviewer tasks:

See tasks:
  1. Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
  2. Make sure all layers are correctly named and organized.
  3. Stress test final component by changing the component's size, editing content, and changing any available variants and properties.
  4. Ensure component descriptions and external documentation links are clear and accurate.
  5. Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue.
  6. Assign to a Figma maintainer for final review (make sure they have edit permissions in Figma).
  7. Ask a Foundations designer to review your design (ensure they have edit permissions in Figma).

Maintainer tasks:

See tasks:
  1. Review and approve assignee’s changes. questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
  2. Consider adding a new version to the file's version history to indicate the state prior to merging the changes. The name of the version and description of the changes are saved in the file history and provide a meaningful reference point.
  3. Merge the branch or add the changes or additions to the target file.
    1. Ensure that all styles and components now belong to the target file.
    2. For changes to the Component Library file, view the components in the Assets panel to ensure they align with our asset library structure guidelines.
  4. When applicable, publish any library changes along with a clear commit message.
  5. If the file's version history isn't clear, name the latest version and update the details so it's clear what change had been made.
Edited by Libor Vanc