Skip to content

Add missing test cases for s3 IAM checks

Steve Xuereb requested to merge add-test-cases-for-s3 into master

What does this MR do?

Add missing test cases for s3 IAM checks

Why was this MR needed?

ShouldUseIAMCredentials checks if any of the fields are empty if one of them is empty it will return true.

Most test cases are missing, the only thing tested is when all fields are empty.

In !1365 (closed) (comment 183850614) a change was made that would have broken the check but CI did not catch this.

Are there points in the code the reviewer needs to double check?

  • If I missed any other permutation I didn't think of.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased
Edited by Steve Xuereb

Merge request reports