Skip to content

Allow the use of instance roles with isolated amazon regions for S3 cache

Casey Vockrodt requested to merge casey.vockrodt/gitlab-runner:feature/use-isolated-amazon-for-s3-cache into main

What does this MR do?

Adds support for S3 caching with isolated amazon regions w/ DNS suffixes other than amazonaws.com

Why was this MR needed?

Because if an instance role is being used, the runner assumes it should be pointing to amazonaws.com when that would not be the case if using an isolated (not connected to the internet) amazon region

Are there points in the code the reviewer needs to double check?

I'm not positive that minio supports isolated regions, but adding this code would at least put the onus on the minio devs to implement. As far as I can tell, this MR should not break any current functionality surrounding S3 cache.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

fix #4227 (closed)

Merge request reports