Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gitlab-runner
gitlab-runner
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 2,099
    • Issues 2,099
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 208
    • Merge requests 208
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • gitlab-runnergitlab-runner
  • Merge requests
  • !994

Merged
Created Aug 09, 2018 by Tomasz Maczukin@tmaczukinMaintainer0 of 4 tasks completed0/4 tasks

Make session and metrics server initialization logging consistent

  • Overview 6
  • Commits 1
  • Pipelines 6
  • Changes 1

What does this MR do?

A little cleanup by aligning how logs from commands.RunCommand.setupMetricsAndDebugServer and commands.RunCommand.setupSessionServer are generated.

Why was this MR needed?

Are there points in the code the reviewer needs to double check?

This MR is based on !934 (merged) and !991 (merged). It should be merged after both mentioned MRs.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Edited Aug 18, 2018 by Tomasz Maczukin
Assignee
Assign to
Reviewer
Request review from
11.3
Milestone
11.3 (Past due)
Assign milestone
Time tracking
Source branch: make-session-and-metrics-server-initialization-logging-consistent