Log 'metrics_server' deprecation not only when the setting is used
What does this MR do?
Fixes logging about usage of deprecated metrics_server setting.
Why was this MR needed?
With !838 (merged) we've renamed metrics_server to listen_address and deprecated the old setting. But there is a bug in logging the deprecation - instead of log it on startup when metrics_server is used, it's logged always when listen_address is not used. Even if metrics are not enabled at all, neither with old nor new setting. This generates noise.
Are there points in the code the reviewer needs to double check?
Does this MR meet the acceptance criteria?
-
Documentation created/updated - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Branch has no merge conflicts with master(if you do - rebase it please)